Skip to content

Fixed bug #23 : QA could hung when stopping trace session #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2024
Merged

Fixed bug #23 : QA could hung when stopping trace session #25

merged 1 commit into from
Aug 6, 2024

Conversation

hvlad
Copy link
Member

@hvlad hvlad commented Jun 13, 2024

No description provided.

@hvlad hvlad self-assigned this Jun 13, 2024
@hvlad hvlad requested a review from pcisar June 13, 2024 13:57
@hvlad hvlad linked an issue Jun 13, 2024 that may be closed by this pull request
QA could hung when stopping trace session #23
Closed
@hvlad hvlad mentioned this pull request Jul 10, 2024
Closed
@hvlad
Copy link
Member Author

hvlad commented Jul 10, 2024

Any problem with this PR ?

pcisar
pcisar reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@pcisar pcisar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand it correctly that proposed change do not even try to stop the trace session properly? If that's the case, is it because the srv.trace.stop() call hangs or throws an exception?

@hvlad
Copy link
Member Author

hvlad commented Aug 1, 2024

Do I understand it correctly that proposed change do not even try to stop the trace session properly?

It signal trace_thread to break poll loop and disconnect from services manager - it stops trace session properly.

@pavel-zotov pavel-zotov merged commit 5061dc9 into master Aug 6, 2024
@pavel-zotov
Copy link
Contributor

Merged after talk with Vlad and Alex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcisar pcisar pcisar left review comments

Assignees

@hvlad hvlad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QA could hung when stopping trace session
3 participants
@hvlad @pavel-zotov @pcisar